coolaj86
/
human-readable-ids.js
1
0
Forka 0
Codice Problemi 2 Pull Requests 1 Rilasci Wiki Attività
Etichette Traguardi

Allow custom format for random values #3

Aperto
Ghost vorrebbe unire 2 commit da <deleted>:master a master
Conversazione 6 Commit 2 File modificati 3
Ghost 3 anni fa ha commentato
Non ci sono ancora contenuti.
Ghost aggiunto 1 commit 3 anni fa
Ghost 3 anni fa ha commentato

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
coolaj86 3 anni fa ha commentato
Proprietario

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost aggiunto 1 commit 3 anni fa
Ghost 3 anni fa ha commentato

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Ghost 3 anni fa ha commentato

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Ghost 3 anni fa ha commentato

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
coolaj86 3 anni fa ha commentato
Proprietario

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
Questa pull request è rovinata a causa di informazioni mancanti del fork.
Effettua l'accesso per partecipare alla conversazione.
Revisori
Richiedi revisione
Nessun revisore
Etichette
Applica etichette
Pulisci le etichette
Nessun elemento
Nessuna etichetta
Traguardo
Imposta traguardo
Milestone pulita
Nessun elemento
Nessuna milestone
Assegnatari
Assegna utenti
Cancella assegnatari
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza

Nessuna data di scadenza impostata.

Dipendenze

Questo problema attualmente non ha alcuna dipendenza.

Scrivi Anteprima
Caricamento…
Annulla
Salva
Non ci sono ancora contenuti.
Elimina branch '<deleted>:master'

L'eliminazione di un branch è definitiva. È un'operazione che NON PUÒ essere annullata. Continuare?

No
Sì