Allow custom format for random values #3

Aperto
Ghost vorrebbe unire 2 commit da (deleted):master a master
First-time contributor
No description provided.
Ghost aggiunto 1 commit 2020-12-30 01:01:29 +00:00
Autore
First-time contributor

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
Proprietario

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost aggiunto 1 commit 2021-01-02 17:14:02 +00:00
Autore
First-time contributor

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Autore
First-time contributor

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Autore
First-time contributor

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
Proprietario

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
Questa pull request è rovinata a causa di informazioni mancanti del fork.
Effettua l'accesso per partecipare alla conversazione.
No Reviewers
Nessuna etichetta
2 Partecipanti
Notifiche
Data di scadenza
Nessuna data di scadenza impostata.
Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/human-readable-ids.js#3
No description provided.