Labels Mijlpalen

Allow custom format for random values #3

Open

Ghost wil 2 commits van <deleted>:master samenvoegen met master

trekken van: <deleted>:master

samenvoegen met: coolaj86:master

coolaj86:master

Discussie 6 Commits 2 Bestanden gewijzigd 3

Ghost commented 3 jaren geleden

Er is nog geen inhoud.

Ghost toegevoegd 1 commit 3 jaren geleden

14bb0026e0 Update 'index.js'

Ghost commented 3 jaren geleden

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.

coolaj86 commented 3 jaren geleden

Eigenaar

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Ghost toegevoegd 1 commit 3 jaren geleden

9e447b2a11 Add docs

Ghost commented 3 jaren geleden

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed

Ghost commented 3 jaren geleden

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Ghost commented 3 jaren geleden

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians

coolaj86 commented 3 jaren geleden

Eigenaar

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)

Deze pull-aanvraag is ongeldig wegens missende fork-informatie.

Log in om deel te nemen aan deze discussie.

Reviewers

Beoordeling aanvragen

Geen beoordelaars

Labels

Labels toepassen

Verwijder labels

Geen items

Geen label

Mijlpaal

Stel mijlpaal in

Verwijder mijlpaal

Geen items

Geen mijlpaal

Toegewezen aan

Gebruikers toewijzen

Verwijder toegewezen aan

Niet toegewezen

2 deelnemers

Notificaties

Abonneren

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Deze pull-aanvraag heeft momenteel geen afhankelijkheden.

Schrijf Voorbeeld

Laden…

Annuleren

Opslaan

Er is nog geen inhoud.