Allow custom format for random values #3

Ghost · 2020-12-30T01:01:28Z

Ghost skomentował(-a)

2020-12-30 01:01:28 +00:00

First-time contributor

No description provided.

Ghost dodał(-a) 1 commit 2020-12-30 01:01:29 +00:00

Update 'index.js' 14bb0026e0

Ghost skomentował(-a)

2020-12-31 19:36:30 +00:00

First-time contributor

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.

coolaj86 skomentował(-a)

2020-12-31 20:24:41 +00:00

Właściciel

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Ghost dodał(-a) 1 commit 2021-01-02 17:14:02 +00:00

Add docs 9e447b2a11

Ghost skomentował(-a)

2021-01-02 17:14:58 +00:00

First-time contributor

@coolaj86 This is ready for review. Let me know if you want anything changed

Ghost skomentował(-a)

2021-01-02 18:05:56 +00:00

First-time contributor

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Ghost skomentował(-a)

2021-01-12 03:19:37 +00:00

First-time contributor

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians

coolaj86 skomentował(-a)

2021-01-13 18:36:55 +00:00

Właściciel

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)

Ten Pull Request jest uszkodzony ze względu na brakujące informacje o forku.

Zaloguj się, aby dołączyć do tej rozmowy.

Uczestnicy 2

Powiadomienia

Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: coolaj86/human-readable-ids.js#3