Allow custom format for random values #3

Отворено
Ghost wants to merge 2 commits from <deleted>:master into master
Ghost коментирира пре 3 година
Још нема садржаја.
Ghost added 1 commit пре 3 година
Ghost коментирира пре 3 година

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.
coolaj86 коментирира пре 3 година
Власник

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
Ghost added 1 commit пре 3 година
Ghost коментирира пре 3 година

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed
Ghost коментирира пре 3 година

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.
Ghost коментирира пре 3 година

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians
coolaj86 коментирира пре 3 година
Власник

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)
This pull request is broken due to missing fork information.
Пријавите се да се прикључе у овом разговору.
No reviewers
Нема лабеле
Нема фазе
No Assignees
2 учесника
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
Још нема садржаја.