Etiketter Milstenar

Allow custom format for random values #3

Öppen

Ghost vill sammanfoga 2 incheckningar från s[2]s in i master

pulla från: <deleted>:master

merga in i: coolaj86:master

coolaj86:master

Konversation 6 Incheckningar 2 Ändrade Filer 3

Ghost kommenterad 3 år sedan

Det finns inget innehåll än.

Ghost lade till 1 commit 3 år sedan

14bb0026e0 Update 'index.js'

Ghost kommenterad 3 år sedan

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of a, n, and #.

@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of `a`, `n`, and `#`.

coolaj86 kommenterad 3 år sedan

Ägare

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.

Ghost lade till 1 commit 3 år sedan

9e447b2a11 Add docs

Ghost kommenterad 3 år sedan

@coolaj86 This is ready for review. Let me know if you want anything changed

@coolaj86 This is ready for review. Let me know if you want anything changed

Ghost kommenterad 3 år sedan

Another approach here could be that the format for .get() is something like this:

.get("num-adj-anim-verb") where separator is required as [-_ ] and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Another approach here could be that the format for `.get()` is something like this: `.get("num-adj-anim-verb")` where separator is required as `[-_ ]` and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.

Ghost kommenterad 3 år sedan

Bump. Thoughts?

I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:

.get("#-anim") - 9 pandas
.get("##-anim") - 42 fish
.get("###-anim") - 101 dalmatians

Bump. Thoughts? I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as: `.get("#-anim")` - 9 pandas `.get("##-anim")` - 42 fish `.get("###-anim")` - 101 dalmatians

coolaj86 kommenterad 3 år sedan

Ägare

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.

(also, I didn't see the notification last week)

Just pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday. (also, I didn't see the notification last week)

Pull-requesten är trasig pågrund av oexisterande information on forken.

Logga in för att delta i denna konversation.

Granskare

Begär granskning

Inga granskare

Etiketter

Tillämpa etiketter

Rensa etiketter

Inga objekt

Ingen Etikett

Milsten

Ange milstolpe

Rensa milstenar

Inga objekt

Ingen Milsten

Tilldelade

Tilldela användare

Rensa tilldelade

Ingen tilldelad

2 Deltagare

Notiser

Prenumerera

Förfallodatum

Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

Denna pull-förfrågan har för närvarande inga beroenden.

Skriv Förhandsgranska

Laddar…

Avbryt

Spara

Det finns inget innehåll än.