coolaj86
/
le-sni-auto.js
1
0
Vork 0
Code Kwesties Pull-aanvragen Publicaties Wiki Activiteit

noop on async getCertificates error #2

Samengevoegd
coolaj86 heeft 1 commits samengevoegd van :master naar master 2019-04-15 17:36:25 +00:00
Discussie 5 Commits 1 Bestanden gewijzigd 1 +4 -1
Ghost reageerde 2019-01-30 04:10:00 +00:00
First-time contributor
Link kopiëren

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.
coolaj86 reageerde 2019-01-31 15:04:18 +00:00
Eigenaar
Link kopiëren

Thanks! I’ll merge this in today.

What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?

Thanks! I’ll merge this in today. What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?
Ghost reageerde 2019-01-31 21:00:13 +00:00
Author
First-time contributor
Link kopiëren

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.
Ghost reageerde 2019-04-15 04:52:16 +00:00
Author
First-time contributor
Link kopiëren

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.
coolaj86 reageerde 2019-04-15 16:36:06 +00:00
Eigenaar
Link kopiëren

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.
coolaj86 heeft deze pull request gesloten 2019-04-15 17:36:25 +00:00
coolaj86 reageerde 2019-04-15 17:38:35 +00:00
Eigenaar
Link kopiëren

Published le-sni-auto@2.1.9

Published le-sni-auto@2.1.9
Log in om deel te nemen aan deze discussie.
Reviewers
Geen beoordelaars
Labels
Verwijder labels
Geen items
Geen label
Mijlpaal
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Verwijder toegewezen aan
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/le-sni-auto.js#2
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?