noop on async getCertificates error #2

Scalone

coolaj86 scala 1 commity/ów z :master do master 2019-04-15 17:36:25 +00:00

Dyskusja 5 Commity 1 Zmodyfikowane pliki 1 +4 -1

Ghost skomentował(-a) 2019-01-30 04:10:00 +00:00

First-time contributor

Skopiuj link

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.

coolaj86 skomentował(-a) 2019-01-31 15:04:18 +00:00

Właściciel

Skopiuj link

Thanks! I’ll merge this in today.

What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?

Thanks! I’ll merge this in today. What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?

Ghost skomentował(-a) 2019-01-31 21:00:13 +00:00

Author

First-time contributor

Skopiuj link

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.

Ghost skomentował(-a) 2019-04-15 04:52:16 +00:00

Author

First-time contributor

Skopiuj link

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.

coolaj86 skomentował(-a) 2019-04-15 16:36:06 +00:00

Właściciel

Skopiuj link

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.

coolaj86 zamknął(-ęła) ten pull request 2019-04-15 17:36:25 +00:00

coolaj86 skomentował(-a) 2019-04-15 17:38:35 +00:00

Właściciel

Skopiuj link

Published le-sni-auto@2.1.9

Published le-sni-auto@2.1.9

Zaloguj się, aby dołączyć do tej rozmowy.

Recenzenci

No Reviewers

Etykiety

Brak elementów

Brak etykiety

Kamień milowy

Brak elementów

Brak kamienia milowego

Przypisani

Usuń przypisanych

coolaj86

Brak przypisanych

Uczestnicy 2

Powiadomienia

Subskrybuj

Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Reference: coolaj86/le-sni-auto.js#2

No description provided.