noop on async getCertificates error #2

Birleştirildi
coolaj86 2019-04-15 17:36:25 +00:00 :master içindeki 1 işlemeyi master ile birleştirdi
First-time contributor

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.

This should fix #1. Otherwise, I'm happy to make a patch for other suggestions.
Sahibi

Thanks! I’ll merge this in today.

What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?

Thanks! I’ll merge this in today. What if we put a log in there too? Is there a case where you think that would be helpful or is it just noise?
Yazar
First-time contributor

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.

Yeah, I think it can be noisy for end user, but helpful for dev. Adding it now.
Yazar
First-time contributor

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.

Hi, this is still pending. Could you take a look at this? I've added the logging to the patch.
Sahibi

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.

Thanks for the follow up. I must have gotten distracted. I've got this back in the queue for today.
coolaj86 2019-04-15 17:36:25 +00:00 değişiklik isteğini kapattı
Sahibi

Published le-sni-auto@2.1.9

Published le-sni-auto@2.1.9
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Etiket Yok
Kilometre Taşı Yok
Atanan Kişi Yok
2 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: coolaj86/le-sni-auto.js#2
Herhangi bir açıklama sağlanmadı.