Updates to SPEC tests from doing my own implementation #6

Ghost · 2019-02-17T17:52:01Z

Ghost comentado

2019-02-17 17:52:01 +00:00

Contribuyente por primera vez

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt.

In addition I updated the certificate.setAsync test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt. In addition I updated the `certificate.setAsync` test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324

Ghost cambió el título de ~~Updates to tests SPEC from doing my own implementation~~ a Updates to SPEC tests from doing my own implementation

2019-02-17 17:52:13 +00:00

coolaj86 comentado

2019-02-20 10:03:00 +00:00

Propietario

Thanks so much!

coolaj86 comentado

2019-03-30 16:02:59 +00:00

Propietario

I forgot to merge this, but I just merged it in manually.

coolaj86 cerró este pull request

2019-03-30 16:02:59 +00:00

Se cerró la solicitud de incorporación

Este pull request no se puede reabrir porque la rama fue eliminada.

Inicie sesión para unirse a esta conversación.

2 participantes

Notificaciones

Fecha de vencimiento

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: coolaj86/le-store-SPEC.js#6