Updates to SPEC tests from doing my own implementation #6

Ghost · 2019-02-17T17:52:01Z

Ghost 評論

2019-02-17 17:52:01 +00:00

First-time contributor

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt.

In addition I updated the certificate.setAsync test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt. In addition I updated the `certificate.setAsync` test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324

Ghost changed title from ~~Updates to tests SPEC from doing my own implementation~~ to Updates to SPEC tests from doing my own implementation

2019-02-17 17:52:13 +00:00

coolaj86 評論

2019-02-20 10:03:00 +00:00

管理員

Thanks so much!

coolaj86 評論

2019-03-30 16:02:59 +00:00

管理員

I forgot to merge this, but I just merged it in manually.

coolaj86 closed this pull request

2019-03-30 16:02:59 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

登入才能加入這對話。

2 參與者

訊息

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/le-store-SPEC.js#6