coolaj86/le-store-SPEC.js
1
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Updates to SPEC tests from doing my own implementation #6

Closed
Ghost wants to merge 0 commits from (deleted):tests into tests
pull from: (deleted):tests
merge into: coolaj86:tests
Conversation 2 Commits - Files Changed -
Ghost commented 2019-02-17 17:52:01 +00:00
First-time contributor
Copy Link

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt.

In addition I updated the certificate.setAsync test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324

I needed to make one little tweak to the tests for a MongoDB. An empty receipt object was being filtered off of the store I would not get it back and the test would fail. I tweaked the test to put something in the receipt. In addition I updated the `certificate.setAsync` test to only pass in a single argument and a callback per https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L324
Ghost changed title from Updates to tests SPEC from doing my own implementation to Updates to SPEC tests from doing my own implementation 2019-02-17 17:52:13 +00:00
coolaj86 commented 2019-02-20 10:03:00 +00:00
Owner
Copy Link

Thanks so much!

Thanks so much!
coolaj86 commented 2019-03-30 16:02:59 +00:00
Owner
Copy Link

I forgot to merge this, but I just merged it in manually.

I forgot to merge this, but I just merged it in manually.
coolaj86 closed this pull request 2019-03-30 16:02:59 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/le-store-SPEC.js#6
No description provided.
Delete Branch "(deleted):tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?