coolaj86
/
le-store-certbot.js
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add missing field to regr.json. #1

Merged
coolaj86 merged 1 commits from :new-authzr-uri into master 2018-05-21 17:13:38 +00:00
Conversation 5 Commits 1 Files Changed 1 +9 -1
Ghost commented 2018-05-15 13:51:30 +00:00
First-time contributor
Copy Link

When using generated configs with older certbot versions,
i.e. <0.11, certbot bombs out without new_authzr_uri.

When using generated configs with older certbot versions, i.e. <0.11, certbot bombs out without new_authzr_uri.
coolaj86 commented 2018-05-15 16:48:11 +00:00
Owner
Copy Link

We now use ACME draft-11 / Let's Encrypt v02 by default, not v01.

We also don't want to assume and hard-code the use of the Let's Encrypt brand ACME provider.

I think that right around here https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js we need to add args._acmeUrls.newReg as a parameter and then use that instead of the hard-coded url.

Will you test that and make a PR? I'll try to publish today if you can make the change, confirm that that works with v01 and certbot, and I can confirm that it works with v02 without certbot.

We now use ACME draft-11 / Let's Encrypt v02 by default, not v01. We also don't want to assume and hard-code the use of the Let's Encrypt brand ACME provider. I think that right around here https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js we need to add `args._acmeUrls.newReg` as a parameter and then use that instead of the hard-coded url. Will you test that and make a PR? I'll try to publish today if you can make the change, confirm that that works with v01 and certbot, and I can confirm that it works with v02 without certbot.
Ghost commented 2018-05-16 12:25:33 +00:00
Author
First-time contributor
Copy Link

Was there supposed to be a line number in there?

Was there supposed to be a line number in there?
coolaj86 commented 2018-05-17 00:04:44 +00:00
Owner
Copy Link

Yes... there was.

I think I was referencing Lines 92 and 109

https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L109

Yes... there was. I think I was referencing Lines 92 and 109 https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L109
Ghost commented 2018-05-21 13:37:01 +00:00
Author
First-time contributor
Copy Link

Finally got around to this.

greenlock change: coolaj86/greenlock.js#13

I also updated this PR to use that field.

Finally got around to this. greenlock change: https://git.coolaj86.com/coolaj86/greenlock.js/pulls/13 I also updated this PR to use that field.
coolaj86 closed this pull request 2018-05-21 17:13:38 +00:00
coolaj86 commented 2018-05-21 17:15:37 +00:00
Owner
Copy Link

Thanks much.

Merged and published as v2.1.2.

Now going to check out the other...

Thanks much. Merged and published as v2.1.2. Now going to check out the other...
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/le-store-certbot.js#1
No description provided.
Delete Branch ":new-authzr-uri"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?