Add missing field to regr.json. #1

Ghost · 2018-05-15T13:51:30Z

Ghost прокомментировал(а)

2018-05-15 13:51:30 +00:00

Новый участник

When using generated configs with older certbot versions,
i.e. <0.11, certbot bombs out without new_authzr_uri.

When using generated configs with older certbot versions, i.e. <0.11, certbot bombs out without new_authzr_uri.

coolaj86 прокомментировал(а)

2018-05-15 16:48:11 +00:00

Владелец

We now use ACME draft-11 / Let's Encrypt v02 by default, not v01.

We also don't want to assume and hard-code the use of the Let's Encrypt brand ACME provider.

I think that right around here https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js we need to add args._acmeUrls.newReg as a parameter and then use that instead of the hard-coded url.

Will you test that and make a PR? I'll try to publish today if you can make the change, confirm that that works with v01 and certbot, and I can confirm that it works with v02 without certbot.

We now use ACME draft-11 / Let's Encrypt v02 by default, not v01. We also don't want to assume and hard-code the use of the Let's Encrypt brand ACME provider. I think that right around here https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js we need to add `args._acmeUrls.newReg` as a parameter and then use that instead of the hard-coded url. Will you test that and make a PR? I'll try to publish today if you can make the change, confirm that that works with v01 and certbot, and I can confirm that it works with v02 without certbot.

Ghost прокомментировал(а)

2018-05-16 12:25:33 +00:00

Автор

Новый участник

Was there supposed to be a line number in there?