coolaj86
/
rsa-compat.js
1
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

Fix keypairs module reference in lib/rsa.js #5

Closed
Ghost wants to merge 1 commits from (deleted):204-requirefix into master
pull from: (deleted):204-requirefix
merge into: coolaj86:master
Conversation 2 Commits 1 Files Changed 1 +1 -1
Ghost commented 2019-03-15 03:22:09 +00:00
First-time contributor
Copy Link

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 commented 2019-03-15 03:44:14 +00:00
Owner
Copy Link

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 closed this pull request 2019-03-15 03:44:14 +00:00
coolaj86 commented 2019-03-15 03:44:38 +00:00
Owner
Copy Link

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/rsa-compat.js#5
No description provided.
Delete Branch "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?