coolaj86
/
rsa-compat.js
1
0
Fork 0
Koodi Ongelmat 1 Pull-pyynnöt Julkaisut Toiminta

Fix keypairs module reference in lib/rsa.js #5

Suljettu
Ghost haluaa yhdistää 1 committia lähteestä (deleted):204-requirefix kohteeseen master
vedä kohteesta: (deleted):204-requirefix
merge into: coolaj86:master
Keskustelu 2 Commitit 1 Muuttuneet tiedostot 1 +1 -1
Ghost kommentoi 2019-03-15 03:22:09 +00:00
First-time contributor
Kopioi linkki

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 kommentoi 2019-03-15 03:44:14 +00:00
Omistaja
Kopioi linkki

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 closed this pull request 2019-03-15 03:44:14 +00:00
coolaj86 kommentoi 2019-03-15 03:44:38 +00:00
Omistaja
Kopioi linkki

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Tunnisteet
Tyhjennä tunnisteet
Ei kohteita
Ei tunnistetta
Merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Käsittelijä
Tyhjennä käsittelijä
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: coolaj86/rsa-compat.js#5
No description provided.
Delete Branch "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?