coolaj86/rsa-compat.js
1
0
Forka 0
Codice Problemi 1 Pull Requests Rilasci Attività

Fix keypairs module reference in lib/rsa.js #5

Chiuso
Ghost vorrebbe unire 1 commit da (deleted):204-requirefix a master
esegui un pull da: (deleted):204-requirefix
unisci a: coolaj86:master
Conversazione 2 Commit 1 File modificati 1 +1 -1
Ghost 2019-03-15 03:22:09 +00:00 ha commentato
First-time contributor
Copia link

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 2019-03-15 03:44:14 +00:00 ha commentato
Proprietario
Copia link

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 chiusa questa pull request 2019-03-15 03:44:14 +00:00
coolaj86 2019-03-15 03:44:38 +00:00 ha commentato
Proprietario
Copia link

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

Questa pull request non può essere riaperta perché il branch è stato eliminato.
Effettua l'accesso per partecipare alla conversazione.
Revisori
No Reviewers
Etichette
Nessun elemento
Nessuna etichetta
Traguardo
Nessun elemento
Nessuna milestone
Assegnatari
Cancella assegnatari
coolaj86
Nessuna assegnatario
2 Partecipanti
Notifiche
Data di scadenza
Nessuna data di scadenza impostata.
Dipendenze

Nessuna dipendenza impostata.

Riferimento: coolaj86/rsa-compat.js#5
No description provided.
Delete Branch "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?