coolaj86
/
rsa-compat.js
1
0
포크 0
코드 이슈 1 풀 리퀘스트 릴리즈 활동

Fix keypairs module reference in lib/rsa.js #5

닫힘
Ghost "(deleted):204-requirefix 에서 master 로 1 commits 를 머지하려 합니다"
다음으로부터 풀: (deleted):204-requirefix
병합하기: coolaj86:master
대화 2 커밋 1 파일 변경됨 1 +1 -1
Ghost 코멘트됨, 2019-03-15 03:22:09 +00:00
First-time contributor
Copy Link

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 코멘트됨, 2019-03-15 03:44:14 +00:00
소유자
Copy Link

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 closed this pull request 2019-03-15 03:44:14 +00:00
coolaj86 코멘트됨, 2019-03-15 03:44:38 +00:00
소유자
Copy Link

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
"로그인하여 이 대화에 참여"
리뷰어
No reviewers
레이블
레이블 초기화
No items
레이블 없음
마일스톤
마일스톤 초기화
No items
마일스톤 없음
담당자
담당자 초기화
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: coolaj86/rsa-compat.js#5
No description provided.
Delete Branch "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?