coolaj86
/
rsa-compat.js
1
0
Atdalīts 0
Kods Problēmas 1 Izmaiņu pieprasījumi Laidieni Aktivitāte

Fix keypairs module reference in lib/rsa.js #5

Slēgta
Ghost vēlas sapludināt 1 revīzijas no (deleted):204-requirefix uz master
salīdzināmais: (deleted):204-requirefix
pamata: coolaj86:master
Saruna 2 Revīzijas 1 Izmainītie faili 1 +1 -1
Ghost komentēja 2019-03-15 03:22:09 +00:00
First-time contributor
Kopēt saiti

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 komentēja 2019-03-15 03:44:14 +00:00
Īpašnieks
Kopēt saiti

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 aizvēra šo izmaiņu pieprasījumu 2019-03-15 03:44:14 +00:00
coolaj86 komentēja 2019-03-15 03:44:38 +00:00
Īpašnieks
Kopēt saiti

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Izmaiņu pieprasījums aizvērts

Šo izmaiņu pieprasīju nevar atkāroti atvērt, jo atzars ir izdzēsts.
Pierakstieties, lai pievienotos šai sarunai.
Recenzenti
Nav recenzentu
Etiķetes
Noņemt etiķetes
Nav neviena ieraksta
Nav etiķešu
Atskaites punkts
Notīrīt atskaites punktus
Nav neviena ieraksta
Nav atskaites punktu
Atbildīgie
Noņemt atbildīgo
Nav atbildīgo
2 dalībnieki
Paziņojumi
Izpildes termiņš
Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Atsaucas uz: coolaj86/rsa-compat.js#5
No description provided.
Dzēst atzaru "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?