coolaj86
/
rsa-compat.js
1
0
Vork 0
Code Kwesties 1 Pull-aanvragen Publicaties Activiteit

Fix keypairs module reference in lib/rsa.js #5

Gesloten
Ghost wil 1 commits van (deleted):204-requirefix samenvoegen met master
trekken van: (deleted):204-requirefix
samenvoegen met: coolaj86:master
Discussie 2 Commits 1 Bestanden gewijzigd 1 +1 -1
Ghost reageerde 2019-03-15 03:22:09 +00:00
First-time contributor
Link kopiëren

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 reageerde 2019-03-15 03:44:14 +00:00
Eigenaar
Link kopiëren

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 heeft deze pull request gesloten 2019-03-15 03:44:14 +00:00
coolaj86 reageerde 2019-03-15 03:44:38 +00:00
Eigenaar
Link kopiëren

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

Deze pull-aanvraag kan niet opnieuw worden geopend omdat de branch is verwijderd.
Log in om deel te nemen aan deze discussie.
Reviewers
Geen beoordelaars
Labels
Verwijder labels
Geen items
Geen label
Mijlpaal
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Verwijder toegewezen aan
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/rsa-compat.js#5
No description provided.
Delete Branch "(deleted):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?