coolaj86
/
rsa-compat.js
1
0
Fork 0
Código Issues 1 Pull requests Versões Atividade

Fix keypairs module reference in lib/rsa.js #5

Fechado
Ghost quer aplicar o merge de 1 commits de (excluído):204-requirefix em master
pull de: (excluído):204-requirefix
merge em: coolaj86:master
Conversação 2 Commits 1 Arquivos alterados 1 +1 -1
Ghost comentou 2019-03-15 03:22:09 +00:00
First-time contributor
Copiar link

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 comentou 2019-03-15 03:44:14 +00:00
Proprietário
Copiar link

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 fechou este pull request 2019-03-15 03:44:14 +00:00
coolaj86 comentou 2019-03-15 03:44:38 +00:00
Proprietário
Copiar link

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull Request Fechado

Este pull request não pode ser reaberto porque o branch foi excluído.
Acesse para participar desta conversação.
Revisores
Sem revisor
Etiquetas
Limpar etiquetas
Nenhum item
Sem etiqueta
Marco
Limpar marco
Nenhum item
Sem marco
Responsáveis
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: coolaj86/rsa-compat.js#5
Nenhuma descrição fornecida.
Excluir branch "(excluído):204-requirefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?