Fix keypairs module reference in lib/rsa.js #5

Stängd

Ghost vill sammanfoga 1 incheckningar från s[2]s in i master

pulla från: (deleted):204-requirefix

merga in i: coolaj86:master

coolaj86:master

Konversation 2 Incheckningar 1 Ändrade Filer 1 +1 -1

Ghost kommenterad 2019-03-15 03:22:09 +00:00

First-time contributor

Kopiera länk

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

coolaj86 kommenterad 2019-03-15 03:44:14 +00:00

Ägare

Kopiera länk

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.

coolaj86 closed this pull request 2019-03-15 03:44:14 +00:00

coolaj86 kommenterad 2019-03-15 03:44:38 +00:00

Ägare

Kopiera länk

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

Denna pull-förfrågan kan inte öppnas igen eftersom branchen tagits bort.

Logga in för att delta i denna konversation.

Granskare

Inga granskare

Etiketter

Rensa etiketter

Inga objekt

Ingen Etikett

Milsten

Rensa milstenar

Inga objekt

Ingen Milsten

Tilldelade

Rensa tilldelade

Ingen tilldelad

2 Deltagare

Notiser

Prenumerera

Förfallodatum

Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: coolaj86/rsa-compat.js#5

No description provided.