Fix keypairs module reference in lib/rsa.js #5

已關閉

Ghost wants to merge 1 commits from (deleted):204-requirefix into master

pull from: (deleted):204-requirefix

merge into: coolaj86:master

coolaj86:master

對話內容 2 程式碼提交 1 Files Changed 1 +1 -1

Ghost " 評論 2019-03-15 03:22:09 +00:00"

First-time contributor

Copy Link

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

coolaj86 " 評論 2019-03-15 03:44:14 +00:00"

管理員

Copy Link

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.

coolaj86 closed this pull request 2019-03-15 03:44:14 +00:00

coolaj86 " 評論 2019-03-15 03:44:38 +00:00"

管理員

Copy Link

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

登入 才能加入這對話。

Reviewers

No reviewers

標籤

清除已選取標籤

No items

未選擇標籤

里程碑

清除已選取里程碑

No items

未選擇里程碑

Assignees

Clear assignees

No Assignees

2 參與者

訊息

訂閱

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/rsa-compat.js#5

No description provided.