coolaj86
/
rsa-compat.js
1
0
Fork 0
程式碼 問題 1 合併請求 版本發布 動態

Fix keypairs module reference in lib/rsa.js #5

已關閉
Ghost 請求將 1 次程式碼提交從 (deleted):204-requirefix 合併至 master
拉取自: (deleted):204-requirefix
合併到: coolaj86:master
對話內容 2 程式碼提交 1 檔案變動 1 +1 -1
Ghost 已留言 2019-03-15 03:22:09 +00:00
First-time contributor
複製連結

rsa-compat tries to require a module called Keypairs but fails horribly as it should not be capitalized and should instead be keypairs. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.

`rsa-compat` tries to `require` a module called `Keypairs` but fails horribly as it should not be capitalized and should instead be `keypairs`. This results in the currently released v2.0.4 failing horribly as soon as any other application tries to utilize it.
coolaj86 已留言 2019-03-15 03:44:14 +00:00
擁有者
複製連結

Thanks. I ran the tests on my mac and didn't catch the typo.

Thanks. I ran the tests on my mac and didn't catch the typo.
coolaj86 關閉了這個合併請求 2019-03-15 03:44:14 +00:00
coolaj86 已留言 2019-03-15 03:44:38 +00:00
擁有者
複製連結

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

I would have merged in your commit, but I had a comment from someone else and fixed it before I saw this.

Pull request closed

無法重新開放此合併請求，因為該分支已刪除。
登入 才能加入這對話。
審核者
沒有審核者
標籤
清除已選取標籤
沒有項目
未選擇標籤
里程碑
清除已選取里程碑
沒有項目
未選擇里程碑
負責人
清除負責人
沒有負責人
2 參與者
通知
截止日期
截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: coolaj86/rsa-compat.js#5
No description provided.
刪除分支「(deleted):204-requirefix」

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?