coolaj86
/
telebit.js
1
2
Fork 1
Code Issues 46 Pull Requests 2 Releases Activity

Snapcraft configuration #23

Open
Ghost wants to merge 1 commits from (deleted):feat/snapcraft into next
pull from: (deleted):feat/snapcraft
merge into: coolaj86:next
Conversation 2 Commits 1 Files Changed 3 +37
Ghost commented 2018-11-10 15:54:16 +00:00
First-time contributor
Copy Link

This pr adds the necessary files to build telebit as a snap

Following things need to get fixed:

  • Unsure if the description is the best, just took some stuff from readme
  • When launching telebit it tries to reload the service. Potentially because telebitd runs in isolated system-space and telebit-remote runs in userspace
(unix socket: /home/maciej/snap/telebit/x1/.local/share/telebit/var/run/telebit.sock)

/snap/telebit/x1/lib/node_modules/telebit/bin/telebit-remote.js:309
    if (err) { throw err; }
               ^

Error: Command failed: systemctl --user daemon-reload
/bin/sh: 1: systemctl: Permission denied

    at ChildProcess.exithandler (child_process.js:289:12)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:962:16)
    at Socket.stream.socket.on (internal/child_process.js:381:11)
    at Socket.emit (events.js:182:13)
    at Pipe._handle.close (net.js:606:12)
This pr adds the necessary files to build telebit as a snap Following things need to get fixed: - [ ] Unsure if the description is the best, just took some stuff from readme - [ ] When launching `telebit` it tries to reload the service. Potentially because telebitd runs in isolated system-space and telebit-remote runs in userspace ``` (unix socket: /home/maciej/snap/telebit/x1/.local/share/telebit/var/run/telebit.sock) /snap/telebit/x1/lib/node_modules/telebit/bin/telebit-remote.js:309 if (err) { throw err; } ^ Error: Command failed: systemctl --user daemon-reload /bin/sh: 1: systemctl: Permission denied at ChildProcess.exithandler (child_process.js:289:12) at ChildProcess.emit (events.js:182:13) at maybeClose (internal/child_process.js:962:16) at Socket.stream.socket.on (internal/child_process.js:381:11) at Socket.emit (events.js:182:13) at Pipe._handle.close (net.js:606:12) ```
coolaj86 commented 2018-11-23 19:41:20 +00:00
Owner
Copy Link

What I need to do is move the system loader into the installer and completely out of the main library.

What I need to do is move the system loader into the installer and completely out of the main library.
Ghost commented 2018-11-24 18:17:24 +00:00
Author
First-time contributor
Copy Link

The main reason, I guess, is that the socket is in /root/snap/telebit/ and the user's client searches for it at $HOME/snap/telebit

The main reason, I guess, is that the socket is in `/root/snap/telebit/` and the user's client searches for it at `$HOME/snap/telebit`
This pull request is broken due to missing fork information.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

something new that would be great to add

No Label
feature
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/telebit.js#23
No description provided.
Delete Branch "(deleted):feat/snapcraft"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?