Snapcraft configuration #23

Ghost · 2018-11-10T15:54:16Z

Ghost reageerde

2018-11-10 15:54:16 +00:00

First-time contributor

This pr adds the necessary files to build telebit as a snap

Following things need to get fixed:

Unsure if the description is the best, just took some stuff from readme
When launching telebit it tries to reload the service. Potentially because telebitd runs in isolated system-space and telebit-remote runs in userspace

(unix socket: /home/maciej/snap/telebit/x1/.local/share/telebit/var/run/telebit.sock)

/snap/telebit/x1/lib/node_modules/telebit/bin/telebit-remote.js:309
    if (err) { throw err; }
               ^

Error: Command failed: systemctl --user daemon-reload
/bin/sh: 1: systemctl: Permission denied

    at ChildProcess.exithandler (child_process.js:289:12)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:962:16)
    at Socket.stream.socket.on (internal/child_process.js:381:11)
    at Socket.emit (events.js:182:13)
    at Pipe._handle.close (net.js:606:12)

This pr adds the necessary files to build telebit as a snap Following things need to get fixed: - [ ] Unsure if the description is the best, just took some stuff from readme - [ ] When launching `telebit` it tries to reload the service. Potentially because telebitd runs in isolated system-space and telebit-remote runs in userspace ``` (unix socket: /home/maciej/snap/telebit/x1/.local/share/telebit/var/run/telebit.sock) /snap/telebit/x1/lib/node_modules/telebit/bin/telebit-remote.js:309 if (err) { throw err; } ^ Error: Command failed: systemctl --user daemon-reload /bin/sh: 1: systemctl: Permission denied at ChildProcess.exithandler (child_process.js:289:12) at ChildProcess.emit (events.js:182:13) at maybeClose (internal/child_process.js:962:16) at Socket.stream.socket.on (internal/child_process.js:381:11) at Socket.emit (events.js:182:13) at Pipe._handle.close (net.js:606:12) ```

coolaj86 reageerde

2018-11-23 19:41:20 +00:00

Eigenaar

What I need to do is move the system loader into the installer and completely out of the main library.

Ghost reageerde

2018-11-24 18:17:24 +00:00

First-time contributor

The main reason, I guess, is that the socket is in /root/snap/telebit/ and the user's client searches for it at $HOME/snap/telebit

The main reason, I guess, is that the socket is in `/root/snap/telebit/` and the user's client searches for it at `$HOME/snap/telebit`

Deze pull-aanvraag is ongeldig wegens missende fork-informatie.

Log in om deel te nemen aan deze discussie.

Geen beoordelaars

Geen label

feature

Geen mijlpaal

Niet toegewezen

2 deelnemers

Notificaties

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/telebit.js#23