Update 'lib/html/index.html' #31

Ghost · 2019-05-15T02:21:05Z

Ghost commented

2019-05-15 02:21:05 +00:00

First-time contributor

Rachel's edits to index.html to make information easier to understand.

Ghost reviewed 2019-05-16 15:57:57 +00:00

lib/html/index.html Outdated

Ghost commented

2019-05-16 15:57:57 +00:00

First-time contributor

This is a test of commenting

coolaj86 approved these changes 2019-05-18 04:08:27 +00:00

coolaj86 left a comment

LGTM

lib/html/index.html

						
				@ -51,18 +51,19 @@

				    <div>

				      <h2>You've claimed <span class="js-servername">{{servername}}</span></h2>

coolaj86 commented

2019-05-16 16:02:34 +00:00

another test comment

lib/html/index.html Outdated

						
				@ -56,3 +56,1 @@

				        <pre><code>telebit http ~/Public            # serve a public folder

				telebit http 3000                # forward all https traffic to localhost:3000

				telebit http none                # remove all https handlers</code></pre>

				        <pre><code>~/telebit ssh auto            # to start sharing files and folders locally use this string to begin</code></pre>

coolaj86 commented

2019-05-15 06:00:17 +00:00

~/telebit ssh auto enables you to connect to your computer with ssh-over-https from a different computer

~/telebit ssh other.telebit.xyz is what you would run from another computer to connect back to another one you've installed ssh on

I think we should focus on using http (https) to share files and folders and move the ssh stuff into its own section, for example:

<details>
<summary>SSH (over HTTPS)</summary>
...
</details>

`~/telebit ssh auto` enables you to connect _to_ your computer with ssh-over-https _from_ a different computer `~/telebit ssh other.telebit.xyz` is what you would run from another computer to connect back to another one you've installed ssh on I think we should focus on using http (https) to share files and folders and move the ssh stuff into its own section, for example: ``` <details> <summary>SSH (over HTTPS)</summary> ... </details> ```

lib/html/index.html

						
				@ -59,0 +56,4 @@

				        <pre><code>~/telebit ssh auto            # to start sharing files and folders locally use this string to begin</code></pre>

				        <pre><code>~/telebit http ~/Public            # serve a public folder

				~/telebit http 3000                # forward all https traffic to localhost:3000

				~/telebit http none                # remove all https handlers</code></pre>

coolaj86 commented

2019-05-15 06:01:06 +00:00

Should we update the language to say something like "stop sharing"? Or do you think this is clear enough?

Ghost commented

2019-05-18 15:33:22 +00:00

First-time contributor

Hey,

I'm just seeing this now for some reason. Yeah, that's a good point. I'll plan to add that with the next round of edits. Does that sound good?

Hey, I'm just seeing this now for some reason. Yeah, that's a good point. I'll plan to add that with the next round of edits. Does that sound good?

lib/html/index.html Outdated

						
				@ -62,2 +62,3 @@

				    <p>And remember you can <em>always</em> tunnel <strong>SSH over HTTPS</strong>,

				      even while you're using it for something else:</p>

				      <div class="code-block"><pre><code>telebit ssh auto</code></pre>

				    <p><strong>Here are some examples for those of you that want to access files and folders remotely via SSH tunneling</strong></p>

coolaj86 commented

2019-05-15 06:02:55 +00:00

SSH can be used to access files and folders, but it's primary purpose is to run commands and control the computer. When you open terminal and ssh into another computer, you literally run the commands on that computer's terminal instead of yours and the output comes to your screen instead of showing up on that screen. It's a remote desktop.

SSH _can_ be used to access files and folders, but it's primary purpose is to run commands and _control_ the computer. When you open terminal and ssh into another computer, you literally run the commands on _that_ computer's terminal instead of yours and the output comes to _your_ screen instead of showing up on _that_ screen. It's a remote desktop.

Ghost closed this pull request

2019-05-18 15:34:08 +00:00

Sign in to join this conversation.

No reviewers

No Label

feature

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/telebit.js#31