more descriptive wait message #33
Loading…
Reference in New Issue
No description provided.
Delete Branch "clarify-waiting"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changed from
waiting...
towaiting for you to check your email
lgtm
@ -540,3 +540,3 @@
return;
}
console.info("waiting...");
console.info(TPLS.remote.waiting.replace(/{email}/, state.config.email));
Have we verified that this code has been run? Does TPLS ever change state/does
TPLS.remote.waiting
ever become unavailable if the state changes?Same with
state.config.email
??? What about a decent fallback? What if the user doesn't enter an email??TPLS is loaded only once, right at the start and it's values are static.
https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/lib/en-us.toml
https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/bin/telebit-remote.js#L15
Still not convinced that TPLS is assured as available, same with state.config. TPLS depends on valid loading of
toml
file. Still, am confident that error would throw before getting to this state/flow. Even ifstate.config.email
is null,replace
op would work, but would throw IFstate.config
isnull
.The user must enter an email. Otherwise it'll loop back.
But approving nonetheless as it is hard to verify the above for now. LGTM.