AJ ONeal coolaj86
  • Provo, UT
  • https://coolaj86.com
  • 6'5 • Technophobic Technologist + Videographer • Go, Rust, Node / VanillaJS (@JSJabber), UX, Security, IoT. Canon 24mm 50mm.

  • Joined on 2017-10-24
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 18:32:56 +00:00
56ec8cbd36 update manual fronting test script
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 18:25:07 +00:00
37d9ac0436 fix typo in options: lexOpts => gl
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 18:18:08 +00:00
7ee525018c package reserved, use pkg
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 18:10:27 +00:00
382a7cc4a9 add telemetry
coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#17 2018-11-05 08:40:41 +00:00
checkAsync found existing certificates - bug when adding an additional alt name to an existing cert

If you watch the second tutorial video at https://git.coolaj86.com/coolaj86/greenlock-express.js you can watch me swap out the approveDomains array for the approveDomains function, which is what I recommend you do.

coolaj86 pushed to v2.5 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 08:37:00 +00:00
08a38a71f1 allow for synchronous return
coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#22 2018-11-05 08:27:01 +00:00
Issue with renewal

Well, part of the problem is that the plugin that handled renewal.conf just needs to die. It was based on the original python certbot client and I just haven't had enough motivation to do a rewrite.

coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#15 2018-11-05 08:11:39 +00:00
expected return object for approveDomains

This is now available in a backwards-compatible fashion in the v2.5 branch

coolaj86 pushed to master at coolaj86/greenlock.js-ARCHIVED 2018-11-05 08:11:16 +00:00
a612f4f98b chimney
2abdfcc665 v2.4.8: only do fronting checks on TLS sockets
Compare 2 commits »
coolaj86 pushed to v2.5 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 08:11:04 +00:00
73f2051188 update approveDomains function as per #15
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 08:04:34 +00:00
a612f4f98b chimney
coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#18 2018-11-05 07:43:29 +00:00
checking for req.socket.servername on plain sockets

Fixed in v2.4.8

coolaj86 closed issue coolaj86/greenlock.js-ARCHIVED#18 2018-11-05 07:43:29 +00:00
checking for req.socket.servername on plain sockets
coolaj86 pushed tag v2.4.7 to coolaj86/greenlock.js-ARCHIVED 2018-11-05 07:39:25 +00:00
coolaj86 pushed tag v2.4.8 to coolaj86/greenlock.js-ARCHIVED 2018-11-05 07:39:25 +00:00
coolaj86 pushed to v2.4 at coolaj86/greenlock.js-ARCHIVED 2018-11-05 07:39:24 +00:00
2abdfcc665 v2.4.8: only do fronting checks on TLS sockets
coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#20 2018-11-05 07:34:01 +00:00
Missing domain/altname when requesting several domains certificate

@kudmath please reopen if you feel the issue isn't adequately addressed.

coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#20 2018-11-05 07:33:24 +00:00
Missing domain/altname when requesting several domains certificate

@chanoch I'm pretty laid back about these things. I think both of those are great ideas.

coolaj86 closed issue coolaj86/greenlock.js-ARCHIVED#20 2018-11-05 07:33:24 +00:00
Missing domain/altname when requesting several domains certificate
coolaj86 commented on issue coolaj86/greenlock.js-ARCHIVED#22 2018-11-05 07:31:13 +00:00
Issue with renewal

I think the reason I originally set that up was so that if people are using approveDomains as an array and they aren't doing anything else to actually make the renewal work as they probably want it to, that it would "do the right thing".