coolaj86
/
acme-dns-01-cloudflare.js
1
0
Fork 0
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Added support for authentication tokens + fix for #1 #2

Open
Ghost wants to merge 2 commits from (deleted):master into master
pull from: (deleted):master
merge into: coolaj86:master
Conversation 0 Commits 2 Files Changed 5 +2177 -31
Ghost commented 2019-08-30 14:06:25 +00:00
First-time contributor
Copy Link

I want to use this package, but I am working at a place where I can't be given access to the account's API access token, due to its sheer power over the CloudFlare account.

I can however be granted limited tokens. Due to CloudFlare limitations, there needs to be two tokens - one for listing the domains (and getting the Zone ID that way), and a second one to actually perform the challenges.

This PR implements it. Since I haven't actually tested this "for real" yet, I wanted to at least pass the dry tun tests... so I ended up fixing #1 as well.

EDIT: And I also added and now enforced "standard" via "husky", since it appears to be the style that this project follows.

I want to use this package, but I am working at a place where I can't be given access to the account's API access token, due to its sheer power over the CloudFlare account. I can however be granted limited tokens. Due to CloudFlare limitations, there needs to be two tokens - one for listing the domains (and getting the Zone ID that way), and a second one to actually perform the challenges. This PR implements it. Since I haven't actually tested this "for real" yet, I wanted to at least pass the dry tun tests... so I ended up fixing #1 as well. EDIT: And I also added and now enforced "standard" via "husky", since it appears to be the style that this project follows.
This pull request is broken due to missing fork information.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme-dns-01-cloudflare.js#2
No description provided.
Delete Branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?