greenlock.manager.remove({subject}) doesn't work #56

新しいイシュー

Ghost · 2021-03-17T14:13:41Z

Ghost がコメント

2021-03-17 14:13:41 +00:00

greenlock.manager.remove({subject}) doesn't work, it never finds a site by subject`.

npx greenlock remove --subject has the same problem.

I've tried debugging and this is what I came up with:

In
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203
the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take servername or altname.
The remove function in the wrapper calls the merged remove function, which calls mega.get:
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475
The opts to mega.remove at this time are {subject}.

mega.get however, uses {servername, wildname}.

A workaround is to use
greenlock.manager.set({subject, deletedAt: Date.now()})

`greenlock.manager.remove({subject}) doesn't work, it never finds a site by `subject`. `npx greenlock remove --subject` has the same problem. I've tried debugging and this is what I came up with: In https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203 the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take `servername` or `altname`. The remove function in the wrapper calls the merged `remove` function, which calls `mega.get`: https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475 The opts to `mega.remove` at this time are `{subject}`. `mega.get` however, uses `{servername, wildname}`. A workaround is to use `greenlock.manager.set({subject, deletedAt: Date.now()})`

Ghost が coolaj86/greenlock-manager-fs.js にて、このイシューを参照

2021-04-09 11:29:03 +00:00

Remove doesn't set deletedAt on disk #1

Ghost が coolaj86/greenlock-manager-test.js にて、このイシューを参照

2021-04-09 11:30:15 +00:00

Test for `remove()` doesn't check either removal or that deletedAt() was set #3

サインインしてこの会話に参加。

1 人の参加者

通知

期日

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: coolaj86/greenlock.js-ARCHIVED#56