greenlock.manager.remove({subject}) doesn't work #56

์˜คํ”ˆ
q42jaap๊ฐ€ 2 ๋…„ ์ „์„ ์˜คํ”ˆ ยท 0๊ฐœ์˜ ์ฝ”๋ฉ˜ํŠธ
q42jaap ์ฝ”๋ฉ˜ํŠธ๋จ, 2 ๋…„ ์ „

greenlock.manager.remove({subject}) doesn't work, it never finds a site by subject`.

npx greenlock remove --subject has the same problem.

I've tried debugging and this is what I came up with:

In
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203
the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take servername or altname.
The remove function in the wrapper calls the merged remove function, which calls mega.get:
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475
The opts to mega.remove at this time are {subject}.

mega.get however, uses {servername, wildname}.

A workaround is to use
greenlock.manager.set({subject, deletedAt: Date.now()})

`greenlock.manager.remove({subject}) doesn't work, it never finds a site by `subject`. `npx greenlock remove --subject` has the same problem. I've tried debugging and this is what I came up with: In https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203 the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take `servername` or `altname`. The remove function in the wrapper calls the merged `remove` function, which calls `mega.get`: https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475 The opts to `mega.remove` at this time are `{subject}`. `mega.get` however, uses `{servername, wildname}`. A workaround is to use `greenlock.manager.set({subject, deletedAt: Date.now()})`
๋กœ๊ทธ์ธํ•˜์—ฌ ์ด ๋Œ€ํ™”์— ์ฐธ์—ฌ
๋ ˆ์ด๋ธ” ์—†์Œ
๋งˆ์ผ์Šคํ†ค ์—†์Œ
๋‹ด๋‹น์ž ์—†์Œ
์ฐธ์—ฌ์ž 1๋ช…
์•Œ๋ฆผ
๋งˆ๊ฐ์ผ

๋งˆ๊ฐ์ผ์ด ์„ค์ •๋˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.

์˜์กด์„ฑ

์ด ์ด์Šˆ๋Š” ์–ด๋– ํ•œ ์˜์กด์„ฑ๋„ ๊ฐ€์ง€์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

๋ถˆ๋Ÿฌ์˜ค๋Š” ์ค‘...
์•„์ง ์ฝ˜ํ…์ธ ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.