coolaj86/greenlock.js-ARCHIVED
3
3
포크 0
코드 이슈 6 풀 리퀘스트 1 릴리즈 활동

greenlock.manager.remove({subject}) doesn't work #56

새로운 이슈
오픈
opened 2021-03-17 14:13:41 +00:00 by Ghost · 0개의 코멘트
Ghost 코멘트됨, 2021-03-17 14:13:41 +00:00
Copy Link

greenlock.manager.remove({subject}) doesn't work, it never finds a site by subject`.

npx greenlock remove --subject has the same problem.

I've tried debugging and this is what I came up with:

In
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203
the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take servername or altname.
The remove function in the wrapper calls the merged remove function, which calls mega.get:
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475
The opts to mega.remove at this time are {subject}.

mega.get however, uses {servername, wildname}.

A workaround is to use
greenlock.manager.set({subject, deletedAt: Date.now()})

`greenlock.manager.remove({subject}) doesn't work, it never finds a site by `subject`. `npx greenlock remove --subject` has the same problem. I've tried debugging and this is what I came up with: In https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203 the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take `servername` or `altname`. The remove function in the wrapper calls the merged `remove` function, which calls `mega.get`: https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475 The opts to `mega.remove` at this time are `{subject}`. `mega.get` however, uses `{servername, wildname}`. A workaround is to use `greenlock.manager.set({subject, deletedAt: Date.now()})`
"로그인하여 이 대화에 참여"
Branch/Tag 가 지정되어 있지 않습니다.
브랜치 태그
레이블
No items
레이블 없음
마일스톤
No items
마일스톤 없음
담당자
담당자 초기화
jshaver coolaj86
담당자 없음
참여자 1명
알림
마감일
마감일이 설정되지 않았습니다.
의존성

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#56
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?