coolaj86/greenlock.js-ARCHIVED
3
3
Atdalīts 0
Kods Problēmas 6 Izmaiņu pieprasījumi 1 Laidieni Aktivitāte

greenlock.manager.remove({subject}) doesn't work #56

Jauna problēma
Atvērta
Ghost atvēra 2021-03-17 14:13:41 +00:00 · 0 komentāri
Ghost komentēja 2021-03-17 14:13:41 +00:00
Kopēt saiti

greenlock.manager.remove({subject}) doesn't work, it never finds a site by subject`.

npx greenlock remove --subject has the same problem.

I've tried debugging and this is what I came up with:

In
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203
the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take servername or altname.
The remove function in the wrapper calls the merged remove function, which calls mega.get:
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475
The opts to mega.remove at this time are {subject}.

mega.get however, uses {servername, wildname}.

A workaround is to use
greenlock.manager.set({subject, deletedAt: Date.now()})

`greenlock.manager.remove({subject}) doesn't work, it never finds a site by `subject`. `npx greenlock remove --subject` has the same problem. I've tried debugging and this is what I came up with: In https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203 the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take `servername` or `altname`. The remove function in the wrapper calls the merged `remove` function, which calls `mega.get`: https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475 The opts to `mega.remove` at this time are `{subject}`. `mega.get` however, uses `{servername, wildname}`. A workaround is to use `greenlock.manager.set({subject, deletedAt: Date.now()})`
Nepieciešams pieteikties, lai pievienotos šai sarunai.
Nav norādīts atzars/tags
Atzari Tagi
Iezīmes
Nav vienumu
Nav iezīmju
Atskaites punkts
Nav vienumu
Nav atskaites punktu
Atbildīgie
Noņemt atbildīgo
jshaver coolaj86
Nav atbildīgo
1 dalībnieki
Paziņojumi
Izpildes termiņš
Izpildes termiņš nav uzstādīts.
Atkarības

Nav atkarību.

Atsaucas uz: coolaj86/greenlock.js-ARCHIVED#56
Nav sniegts apraksts.
Dzēst atzaru "%!s()"

Atzara dzēšana ir neatgriezeniska. Kaut arī izdzēstais zars neilgu laiku var turpināt pastāvēt, pirms tas tiešām tiek noņemts, to vairumā gadījumu NEVAR atsaukt. Vai turpināt?