coolaj86/greenlock.js-ARCHIVED
3
3
複製 0
程式碼 問題管理 6 合併請求 1 版本發佈 Activity

greenlock.manager.remove({subject}) doesn't work #56

建立問題
開啟中
opened 2021-03-17 14:13:41 +00:00 by Ghost · 0 comment
Ghost 評論 2021-03-17 14:13:41 +00:00
Copy Link

greenlock.manager.remove({subject}) doesn't work, it never finds a site by subject`.

npx greenlock remove --subject has the same problem.

I've tried debugging and this is what I came up with:

In
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203
the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take servername or altname.
The remove function in the wrapper calls the merged remove function, which calls mega.get:
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475
The opts to mega.remove at this time are {subject}.

mega.get however, uses {servername, wildname}.

A workaround is to use
greenlock.manager.set({subject, deletedAt: Date.now()})

`greenlock.manager.remove({subject}) doesn't work, it never finds a site by `subject`. `npx greenlock remove --subject` has the same problem. I've tried debugging and this is what I came up with: In https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L203 the public manager api is exposed. The remove function expects {subject}, it checks and refuses to take `servername` or `altname`. The remove function in the wrapper calls the merged `remove` function, which calls `mega.get`: https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/manager-wrapper.js#L475 The opts to `mega.remove` at this time are `{subject}`. `mega.get` however, uses `{servername, wildname}`. A workaround is to use `greenlock.manager.set({subject, deletedAt: Date.now()})`
登入 才能加入這對話。
No Branch/Tag Specified
分支列表 標籤列表
標籤
No items
未選擇標籤
里程碑
No items
未選擇里程碑
Assignees
Clear assignees
jshaver coolaj86
No Assignees
1 參與者
訊息
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#56
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?