coolaj86
/
greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 13 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

Setting directoryUrl doesn't work properly #57

Open
by Ghost opened 3 years ago · 1 comments
Ghost commented 3 years ago

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set.

To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it.

The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.

Setting directoryUrl needs to be done on the manager, but the manager wrapper doesn't have directoryUrl as an allowed option - so Greenlock warns when it is set. To make this more frustrating, Greenlock takes directoryUrl as configuration option and seems to use it in the code (in gconf) - but never actually uses it. The dead code referencing directoryUrl from gconf should be removed, and directoryUrl should be added as a known property for manager options.
coolaj86 commented 3 years ago
Owner

Agreed.

Agreed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
acmev2
dns-challenge-regression-fix
github
greenlock
master
next
node-letsencrypt-python
npm
v1
v2
v2.1
v2.2
v2.3
v2.4
v2.5
v3
v4
wip
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes