coolaj86
/
greenlock-manager-test.js
1
0
Fork 0
Koodi Ongelmat 3 Pull-pyynnöt Julkaisut Wiki Toiminta
Tunnisteet Merkkipaalut
Uusi ongelma

Test for `remove()` doesn't check either removal or that deletedAt() was set #3

Avoinna
by Ghost opened 3 vuotta sitten · 1 kommenttia
Ghost kommentoi 3 vuotta sitten

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.
Ghost kommentoi 3 vuotta sitten

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.
Sign in to join this conversation.
Haaraa/tagia ei määritelty
Branchit Tagit
master
Tunnisteet
Apply labels
Tyhjennä tunnisteet
No items
Ei tunnistetta
Merkkipaalu
Aseta merkkipaalu
Tyhjennä merkkipaalu
No items
Ei merkkipaalua
Käsittelijä
Assign users
Tyhjennä käsittelijä
Ei käsittelijää
1 osallistujaa
Ilmoitukset
Määräpäivä

Määräpäivää ei asetettu.

Riippuvuudet

This issue currently doesn't have any dependencies.

Kirjoita Esikatselu
Ladataan…
Peruuta
Tallenna
Sisältöä ei vielä ole.
Poista haara '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Ei
Kyllä