coolaj86
/
greenlock-manager-test.js
1
0
Bifurcation 0
Code Tickets 3 Demandes d'ajout Versions Wiki Activité
Étiquettes Jalons
Nouveau ticket

Test for `remove()` doesn't check either removal or that deletedAt() was set #3

Ouvert
par Ghost ouverts il y a 3 ans · 1 commentaires
Ghost a commenté il y a 3 ans

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.
Ghost a commenté il y a 3 ans

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.
Connectez-vous pour rejoindre cette conversation.
Aucune branche/tag spécifiés
Branches Tags
master
Étiquettes
Appliquer une étiquette
Effacer les étiquettes
Pas d'élément
Pas d'étiquette
Jalon
Affecter un jalon
Effacer le jalon
Pas d'élément
Aucun jalon
Affecté à
Assigner des utilisateurs
Supprimer les affectations
Pas d'assignataires
1 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

Ce ticket n'a actuellement pas de dépendance.

Écrire Aperçu
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.
Supprimer la branche '%!s(MISSING)'

Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?

Non
Oui