Test for `remove()` doesn't check either removal or that deletedAt() was set #3
Отворено
by Ghost opened пре 3 година
·
1 коментара
Loading…
Reference in new issue
Још нема садржаја.
Delete Branch '%!s(MISSING)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
It seems like the call to
removeshould either fully remove the site entry, or at the very least setdeletedAtto the current time.Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set
deletedAt(at least in my own testing) - something that should be caught by the test suite.Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.
I'm still thinking that remove should be more fully tested.