Etiketter Milstenar

v2.8.0: Fix regression with set challenges being ignored #40

Manually merged

coolaj86 sammanfogade 1 incheckningar från dns-challenge-regression-fix in i master 5 år sedan

Konversation 0 Incheckningar 1 Ändrade Filer 4

coolaj86 kommenterad 5 år sedan

Ägare

Regression Fix

Backwards compatibility madness.
When you Greenlock.create({ }), challenges will be set by default if
not available. This is good... ish.

When you approveDomains() and set opts.challenges, however, those must
be able to override the defaults.

This was just recently broken and the fix seems to be to make the prior
defaults inaccessible, otherwise it becomes really confusing as to why
a set DNS challenge for local, wild, or private domains is not being
preferred to the (failing) http.

All this crap will be cleaned up in v3...

New Feature

Oh, and this adds support for getZones(), the testing of which brought about the need to fix the regression.

# Regression Fix Backwards compatibility madness. When you Greenlock.create({ }), challenges will be set by default if not available. This is good... ish. When you approveDomains() and set opts.challenges, however, those must be able to override the defaults. This was just recently broken and the fix seems to be to make the prior defaults inaccessible, otherwise it becomes really confusing as to why a set DNS challenge for local, wild, or private domains is not being preferred to the (failing) http. All this crap will be cleaned up in v3... # New Feature Oh, and this adds support for `getZones()`, the testing of which brought about the need to fix the regression.

coolaj86 closed this pull request 5 år sedan

coolaj86 ändrade titeln från Fix regression with set challenges being ignored till v2.8.0: Fix regression with set challenges being ignored 5 år sedan

coolaj86 refererade till detta ärende från en incheckning 5 år sedan

Merge pull request #40 from Daplie/v2.x v2.x

The pull request has been manually merged as c8b895633c.

Logga in för att delta i denna konversation.

Granskare

Begär granskning

Inga granskare

Etiketter

Tillämpa etiketter

Rensa etiketter

Inga objekt

Ingen Etikett

Milsten

Ange milstolpe

Rensa milstenar

Inga objekt

Ingen Milsten

Tilldelade

Tilldela användare

Rensa tilldelade

Ingen tilldelad

1 Deltagare

Notiser

Prenumerera

Förfallodatum

Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

Denna pull-förfrågan har för närvarande inga beroenden.

Skriv Förhandsgranska

Laddar…

Avbryt

Spara

Det finns inget innehåll än.