Allow custom format for random values #3
Aberto
Ghost
quer aplicar o merge de 2 commits de <deleted>:master em master
Sem revisor
Sem etiqueta
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências
Atualmente este pull request não tem dependências.
Carregando…
Reference in new issue
Ainda não há conteúdo.
Excluir branch '<deleted>:master'
A exclusão de uma branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?
@coolaj86 thoughts? if you like it I can add documentation to readme. Also this paints the path for allowing verbs etc. Also I'm not hard sold on choices of
a,n, and#.Sounds good to me so far, and it doesn't add much code. Sure, keep going with it.
@coolaj86 This is ready for review. Let me know if you want anything changed
Another approach here could be that the format for
.get()is something like this:.get("num-adj-anim-verb")where separator is required as[-_ ]and can be overriden by the caller. First step is to regex-split by the separator then compare non-single character strings.Bump. Thoughts?
I also thought of allowing the number to be dynamic. Sticking with the long-string identification this could be done as:
.get("#-anim")- 9 pandas.get("##-anim")- 42 fish.get("###-anim")- 101 dalmatiansJust pinging you to let you know I've got this on my todo list. I'm swamped this week. I'll try to take a look by Saturday.
(also, I didn't see the notification last week)